Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added x64 platform again and did some cleanup. #88

Merged
merged 1 commit into from
Feb 5, 2018

Conversation

Selmar
Copy link
Contributor

@Selmar Selmar commented Feb 4, 2018

NOTE It all compiles, but is untested, as I have no access to 3ds max '17 or '18. Can't see a reason why these changes would break anything, but it seems reasonable to verify.

Some project cleanup:

  • Added x64 platform in addition to AnyCPU.
  • Default platform is now x64 again. AnyCPU only needs to be there to compile custom forms so they can be viewed and edited.
  • Fixed release builds (allow unsafe compilation).
  • Cleanup unused hasExporter variable.
  • Removed some unsafe code and void ptrs that seemed useless.

// added x64 platform in addition to AnyCPU
// fixed release builds (allow unsafe compilation)
// cleanup hasExporter variable
// removed some unsafe code and void ptrs that seemed useless
@deltakosh
Copy link
Contributor

Did you try to edit the forms in VS?

@Selmar
Copy link
Contributor Author

Selmar commented Feb 4, 2018

Yes, it works as expected. They don't show in VS unless you (re)compile them for x86.

@deltakosh
Copy link
Contributor

Fine

@deltakosh deltakosh merged commit f5c0c1e into BabylonJS:master Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants