Use correct parent when exporting meshes. Fixes #247 #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, |
|
Updating dlls right now |
|
@frozenbrain Thanks for your work! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the exporter uses the id of the first parent of a mesh as its parentId when exporting it. This results in meshes having an incorrect parent and therefore incorrect positions and rotations in the scene.
In the example scene I attached to issue #247 the Outliner shows the correct object hierarchy:
The exporter however exports both cubes as children of group1:
After the changes in this PR both cubes are exported and grouped correctly:
