Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow overwriting existing bitmaps when saving bitmaps #117

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

Selmar
Copy link
Contributor

@Selmar Selmar commented Mar 19, 2018

this was the default for every other file open I could find in the project (and is quite convenient)

As with the other pull request, could not test with the latest version (I've tested with an older version and it worked fine)

@deltakosh deltakosh requested a review from noalak March 19, 2018 17:36
@noalak
Copy link
Contributor

noalak commented Mar 20, 2018

Hi Selmar,

Just to understand, the error you got when trying to overwrite a bitmap is from GDI+?

I'm using Windows 10 and the exporter is able to overwrite existing bitmaps. Which version of Windows are you using?

@noalak noalak added the 3dsmax label Mar 20, 2018
@Selmar
Copy link
Contributor Author

Selmar commented Mar 20, 2018

Windows 10. There was no error at all. It simply did not replace the existing bitmap.. I have no idea why, but this fixed the problem for us.

@Selmar
Copy link
Contributor Author

Selmar commented Mar 20, 2018

Perhaps it's a 3dsmax issue? We do use different versions if I recall correctly.

@noalak
Copy link
Contributor

noalak commented Mar 21, 2018

Just tested on 3ds max 2015, bitmaps are replaced. Would be nice to know why it doesn't work for you.

Anyway, PR tested and approved.

@noalak noalak merged commit a8b70e0 into BabylonJS:master Mar 21, 2018
@Selmar
Copy link
Contributor Author

Selmar commented Mar 21, 2018

I really have no clue. It is a problem on all computers in the company.

We do use max 2016, not 2015. Other than that, perhaps some strange user permission settings? However, other applications don't seem to have similar problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants