Integrate XR support#9
Merged
Merged
Conversation
ryantrem
requested review from
Alex-MSFT,
CedricGuillemet,
bghgary and
syntheticmagus
bghgary
approved these changes
May 15, 2020
Comment on lines
+71
to
+72
| // TODO: Figure out why this causes the app to crash | ||
| //Napi::Detach(m_env); |
Member
Author
There was a problem hiding this comment.
Yes, this is actually why when I tried to integrate your JSC changes it was crashing in some bgfx cleanup ('cause I also had this line). I just don't want to dig into it now given the JSI work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change brings XR support into the react native layer. One notable change here is with the camera permissions request code I added in the JS layer. See the comments for some explanation, and let me know if anyone has thoughts on the way I currently just "inject" the permissions check into the existing XR session initialization function.
NOTE: This PR depends on BabylonJS/BabylonNative#264. Once this PR is completed, I will update the Babylon Native submodule to master.