Update Babylon Native for native camera fixes #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoPrez
requested review from
CedricGuillemet,
ryantrem,
bghgary and
Alex-MSFT
|
Here are the build results |
|
Testing out a private BN branch to disable the unreachable code warning being thrown on Windows (where CameraDevice hasn't been implemented). I'll get that change committed to Babylon Native and swap back to the master branch after validating the fix and integrating it. |
|
Here are the build results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
This change updates the Babylon Native submodule to the latest. The primary change between the versions is an improvement to the NativeCamera plugin to support the MediaStream constraints WebAPI. Other changes coming in as well are:
Testing
I've tested these changes on iOS and Android where NativeCamera is supported (it's not yet supported on Windows).