Skip to content

Readme and bitcode fixes#40

Merged
ryantrem merged 1 commit into
BabylonJS:masterfrom
ryantrem:ios-fixes-2
Jun 29, 2020
Merged

Readme and bitcode fixes#40
ryantrem merged 1 commit into
BabylonJS:masterfrom
ryantrem:ios-fixes-2

Conversation

@ryantrem

Copy link
Copy Markdown
Member

Two totally separate small changes in this PR:

  1. Fix an incorrect path in the readme, and re-add the flag to disable ARC (I thought this wasn't needed but it turns out it is)
  2. Enable bitcode - I tested this out and everything seems to work fine. Compile time seems about the same, compiled libs are about the same size, and bitcode enabled libs can be consumed by projects that either have bitcode on or off, so as far as I can tell there are no downsides to this change.

Enable bitcode in the BabylonReactNative lib (and its dependencies)
@ryantrem ryantrem merged commit 9ededf2 into BabylonJS:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants