macOS testapp#39
Conversation
|
Apple changed std::filesystem. it's not available any more in experimental. cool. |
|
|
||
| #include <arcana/threading/dispatcher.h> | ||
| #ifndef __APPLE__ | ||
| #include <filesystem> |
There was a problem hiding this comment.
Looks like Xcode 11 supports it: https://developer.apple.com/documentation/xcode_release_notes/xcode_11_release_notes
Clang now supports the C++17 library for iOS 13, macOS 10.15, watchOS 6, and tvOS 13. (50988273)
There was a problem hiding this comment.
So, switching to xcode11 as min req?
There was a problem hiding this comment.
I don't have a lot of experience here. What do you think?
There was a problem hiding this comment.
I'm still in "finding unknowns" mode. Switching to xcode11 just because of std::filesystem is a bit rough. I'd rather spend some time finding the cocoa equivalent with the appropriate abstraction/if def later.
There was a problem hiding this comment.
Still not very happy with the typedef but I removed the #ifdef APPLE in runtime.cpp. So I think it's fine for a 1st iteration.
There was a problem hiding this comment.
Ok, please file an issue after merging.
| }); | ||
| }; | ||
|
|
||
| #ifdef __APPLE__ |
There was a problem hiding this comment.
We should not be spewing __APPLE__ everywhere. The whole point of separating the cpp files is to avoid this.
There was a problem hiding this comment.
I agree. It's related to std::filesystem. Will remove that once I've found a nice way to replace it.
There was a problem hiding this comment.
Can we do this before merging? If not, please make an issue after merging or at least put a comment.
There was a problem hiding this comment.
Before merging sounds like a good idea
|
|
||
| #include <arcana/threading/dispatcher.h> | ||
| #ifndef __APPLE__ | ||
| #include <filesystem> |
There was a problem hiding this comment.
Ok, please file an issue after merging.
|
|
||
| #include <Babylon/Runtime.h> | ||
| #include <napi/napi.h> | ||
| #include <napi/env.h> |
There was a problem hiding this comment.
env is needed in the header
bghgary
left a comment
bghgary
left a comment
There was a problem hiding this comment.
LGTM, couple of minor comments.
2 participants
macOS testapp stub for scriptcore/metal
It compiles, links and runs.
cmake .. -GXcode
then open project with xcode