Skip to content

Re-enable UWP as a build target#26

Merged
syntheticmagus merged 12 commits into
masterfrom
jsm/uwp
Aug 15, 2019
Merged

Re-enable UWP as a build target#26
syntheticmagus merged 12 commits into
masterfrom
jsm/uwp

Conversation

@syntheticmagus

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread Library/CMakeLists.txt
@@ -42,6 +45,13 @@ set(CMAKE_USE_WINSSL ON CACHE BOOL "Set cURL to use WinSSL by default.")
add_subdirectory(Dependencies/curl EXCLUDE_FROM_ALL)
set_property(TARGET libcurl PROPERTY FOLDER Dependencies/curl)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opening an issue to track the following TODO.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#28

public:
explicit RuntimeUWP(ABI::Windows::UI::Core::ICoreWindow* window, const std::string& rootUrl = {});
explicit RuntimeUWP(ABI::Windows::UI::Xaml::Controls::ISwapChainPanel* panel, const std::string& rootUrl = {});

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opening an issue to track the following TODO.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a line in the Feature Backlog (#6)

@CedricGuillemet CedricGuillemet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants