Repository navigation
Wait for packed sprite metadata in visual validation - #1929
Merged
bghgary merged 2 commits intoOct 13, 2026
Merged
Conversation
Scene readiness does not inspect sprite managers, allowing packed-atlas rendering to be skipped while its metadata is still loading. Include SpriteManager.isReady in the existing per-example readiness workaround and enable it for Sprites Pixel Perfect. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
bkaradzic-microsoft
approved these changes
Oct 13, 2026
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
1 open finding
What changed in this PR
Adds an opt-in readiness workaround for visual validation so sprite packed-atlas metadata is loaded before capturing, preventing missing sprite elements in pixel-perfect comparisons.
Changes:
- Extend the
wait-for-readinessworkaround to include sprite-manager readiness (packed-atlas metadata). - Update the native validation runner to wait for both GUI image readiness and sprite-manager readiness.
- Enable
wait-for-readinessfor the “Sprites Pixel Perfect” visual test entry.
| File | Description |
|---|---|
| Documentation/AddingNewValidationTests.md | Documents that wait-for-readiness also waits for sprite-manager readiness / packed-atlas metadata. |
| Apps/Playground/Scripts/validation_native.js | Implements sprite-manager readiness checks alongside existing GUI readiness checks. |
| Apps/Playground/Scripts/config.json | Opts the “Sprites Pixel Perfect” test into the wait-for-readiness workaround. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bghgary
enabled auto-merge (squash)
October 13, 2026 00:31
Copilot stopped reviewing on behalf of
bghgary due to an error
October 13, 2026 00:38
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ab498524-a293-43a8-9d24-59fbdfaa3b67
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Created by Copilot on behalf of @bghgary]
Sprites Pixel Perfect can capture before packed-atlas metadata loads, omitting the blue triangle. Scene readiness does not wait for that metadata.
This remains an opt-in
wait-for-readinessworkaround; tests without it retain their existing behavior. The example still needs to register its sprite manager withScene.addIsReadyCheck.A controlled two-second metadata delay reproduces the failure before the fix (11.964% differing pixels) and passes with it (0.833%, below the 2.5% limit). All 371 enabled visual tests pass locally on Windows with Direct3D 11; 349 are skipped by the existing configuration.