Repository navigation
Update bgfx.cmake to 8fd48e45 - #1928
Merged
bkaradzic-microsoft merged 1 commit intoOct 13, 2026
Merged
bkaradzic-microsoft merged 1 commit into
bkaradzic-microsoft merged 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The dependency update contains broad cross-platform rendering changes that require CI and runtime validation.
0 open findings
What changed in this PR
Updates the bgfx.cmake dependency to the latest upstream revision and aligns installation with the removal of minz.
Changes:
- Pins bgfx.cmake to
937128b5. - Removes the obsolete
minzinstallation target.
| File | Description |
|---|---|
CMakeLists.txt |
Updates the bgfx.cmake revision. |
Install/Install.cmake |
Removes the deleted minz target. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bghgary
approved these changes
Oct 13, 2026
bkaradzic-microsoft
force-pushed
the
update/bgfx-cmake-937128b5
branch
from
October 13, 2026 00:29
28c38c3 to
75ddb9d
Compare
Bump the FetchContent pin to BabylonJS/bgfx.cmake 8fd48e45 (latest master), including bx a9a71f8e. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 559629d6-f895-4967-8bb9-96cd12d083ae
bkaradzic-microsoft
force-pushed
the
update/bgfx-cmake-937128b5
branch
from
October 13, 2026 00:51
1a93454 to
ca802db
Compare
bkaradzic-microsoft
changed the title
bkaradzic-microsoft
enabled auto-merge (squash)
October 13, 2026 02:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the
bgfx.cmakepin on current BabylonNative masterd6e1e174.4b2bdcef530bf6b4bb5d21bc5cef1c49bbf094e8->8fd48e454f624f964ced930af597fa5b4526be18(latest upstream revision).Picks up:
a9a71f8e, MSVCwindows.hdefine fix)Submodule updates:
40cf733e08bd53d8ae4478222124414e8bfeb3ac->f15c1ff18254f3fb85ffc1a669d1870c9714afc959a1e105b6f5dc4600c8bdc24b32499e135df73c->a9a71f8ef449c11042607feaeae0b8f46d22869a671fe06dd7012a1ab85aa931019ed16112909756)Pin-only; no other BabylonNative source changes.
Validation
d6e1e174).