Playground: re-enable 52 more previously-excluded tests#1737
Merged
bkaradzic-microsoft merged 1 commit intoJun 5, 2026
Merged
Conversation
Follow-up to BabylonJS#1715. Now that the Canvas framebuffer-pool fix (BabylonJS#1715) and the Area Lights / OpenPBR shader fixes (BabylonJS#1718 sampler2D split, BabylonJS#1721 zero-init struct locals) have landed, a further 52 previously-excluded Playground tests pass cleanly. Each was verified with a full headless sweep on BOTH Win32 D3D11 and ANGLE OpenGL locally (0 failures, 237 ran / 237 passed). - 23 Area Lights / OpenPBR Analytic Lights tests fixed by BabylonJS#1718 + BabylonJS#1721. - 29 framebuffer-pool cascade victims fixed by BabylonJS#1715. Still excluded (deferred): 6 OpenPBR pixel-diffs, 2 OpenGL-only failures (UV2 Morphing, Vertex Pulling Morph Targets and Bones), the Linux pixel-diff set, and two state corruptors that need their own fixes: cube-with-holes-using-stencil-buffer (dirty stencil) and GLTF Node visibility test (dirties OpenGL state, breaks downstream MeshDebugPluginMaterial). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bkaradzic-microsoft
force-pushed
the
weekend/1573-reenable-52
branch
from
570f917 to
79e2a50
Compare
bkaradzic-microsoft
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Re-enables an additional set of previously excluded Playground visual tests (cascade victims) by removing excludeFromAutomaticTesting entries now that upstream fixes on master have addressed the underlying crash/cascade causes.
Changes:
- Re-enabled 52 Playground tests by removing
excludeFromAutomaticTestingand associatedreasonfields. - Keeps the existing reference-image mappings intact for the re-enabled tests.
bghgary
approved these changes
Jun 5, 2026
bghgary
left a comment
bghgary
left a comment
Contributor
There was a problem hiding this comment.
[Reviewed by Copilot on behalf of @bghgary]
LGTM. Config-only test re-enablement — verified the diff removes only excludeFromAutomaticTesting/reason markers, the two held-back state corruptors stay excluded, and no new exclusions are added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1715. Re-enables 52 more previously-excluded Playground tests that now pass after recent fixes landed on
master:Verification
Each test was verified with a full headless sweep on both Win32 D3D11 and ANGLE OpenGL locally:
0 failures on either backend, and no regressions on the previously-active set (the sweep also confirms no downstream cascade onto already-enabled tests).
Deferred (still excluded)
cube-with-holes-using-stencil-buffer(dirty stencil) andGLTF Node visibility test(dirties OpenGL state -> breaks downstreamMeshDebugPluginMaterial). Each needs its own fix before re-enabling.The two corruptors were pinned down by bisection — re-enabled alone, each produces a downstream cascade — so they are intentionally held back.