Skip to content

Bump SPIRV-Cross to 866e5edcc3407997a3ed62f3edf492f91bcb2629 (Expose more functions #10) #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkaradzic-microsoft merged 6 commits into from
May 15, 2026
Merged

Bump SPIRV-Cross to 866e5edcc3407997a3ed62f3edf492f91bcb2629 (Expose more functions #10) #1695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8f7b0f0
Bump SPIRV-Cross to e1d29b3 (Expose more functions #10)
bkaradzic-microsoft May 14, 2026
fb244f1
Re-enable 8 validation_native.js tests fixed by the SPIRV-Cross bump
bkaradzic-microsoft May 14, 2026
2eea4b6
Bump SPIRV-Cross to 866e5ed (HLSL: expose remaining stubs #11)
bkaradzic May 15, 2026
234b797
Re-enable 10 validation_native.js tests fixed by SPIRV-Cross #11
bkaradzic May 15, 2026
876c898
Exclude OpenGL-broken tests + fix OpenGLWindowsDevOnly build
bkaradzic May 15, 2026
c41065e
Re-disable Prepass SSAO + GUI test (order-dependent state leak)
bkaradzic-microsoft May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 8 additions & 36 deletions Apps/Playground/Scripts/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,8 +872,6 @@
{
"title": "Color correction",
"playgroundId": "#FBH4J7#278",
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"referenceImage": "color-correction.png"
},
{
Expand Down Expand Up @@ -1629,8 +1627,6 @@
"title": "Default pipeline",
"playgroundId": "#NAW8EA#6",
"renderCount": 20,
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"referenceImage": "defaultPipeline.png"
},
{
Expand Down Expand Up @@ -1722,8 +1718,6 @@
{
"title": "Default rendering pipeline",
"playgroundId": "#5XB8YT#2",
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"referenceImage": "DefaultRenderingPipeline.png"
},
{
Expand Down Expand Up @@ -2014,9 +2008,9 @@
{
"title": "Prepass SSAO + sprites",
"playgroundId": "#9RI8CG#187",
"excludedGraphicsApis": ["OpenGL"],
"reason": "OpenGL: BGFX FATAL shader compile error (mediump float vs int conversion in PrePassRenderer fragment shader). Fixable separately; tracked for OpenGL backend follow-up.",
"renderCount": 10,
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"referenceImage": "prepass-ssao-sprites.png"
},
{
Expand All @@ -2038,9 +2032,9 @@
{
"title": "Prepass SSAO + line edges renderer",
"playgroundId": "#T90MQ4#3",
"excludedGraphicsApis": ["OpenGL"],
"reason": "OpenGL: BGFX FATAL shader compile error (mediump float vs int conversion in PrePassRenderer fragment shader). Fixable separately; tracked for OpenGL backend follow-up.",
"renderCount": 10,
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"referenceImage": "prepass-ssao-line-edges.png"
},
{
Expand All @@ -2062,9 +2056,9 @@
{
"title": "Prepass SSAO + GUI",
"playgroundId": "#LLVZ90#4",
"renderCount": 10,
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"reason": "Order-dependent state leak: passes in isolation but produces ~6000-px diff (right at 2.5% errorRatio threshold, flaky in CI) when run after sibling Prepass-SSAO tests in the full sweep on Win32 D3D11. OpenGL also fails (BGFX FATAL 'mediump float' shader compile in PrePassRenderer fragment shader). Re-enable after the order-dependent SSAO state cleanup is investigated.",
"renderCount": 10,
"referenceImage": "prepass-ssao-gui.png"
},
{
Expand Down Expand Up @@ -2143,8 +2137,6 @@
"title": "Prepass MBlur + Lens",
"playgroundId": "#ZEB7H6#23",
"renderCount": 10,
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"referenceImage": "prepass-mb-lens.png"
},
{
Expand Down Expand Up @@ -2234,24 +2226,18 @@
"title": "Thin instances + dynamic buffer resize",
"playgroundId": "#217750#217",
"renderCount": 10,
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"referenceImage": "thin-instances-buffer-resize.png"
},
{
"title": "Instances + render self motion blur",
"playgroundId": "#217750#34",
"renderCount": 10,
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"referenceImage": "instances-renderself-mb.png"
},
{
"title": "Thin instances + render self motion blur",
"playgroundId": "#217750#218",
"renderCount": 10,
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"referenceImage": "thin-instances-renderself-mb.png"
},
{
Expand Down Expand Up @@ -2319,16 +2305,12 @@
"title": "Baked Vertex Animation with Depth Of Field",
"playgroundId": "#JWO4R0#8",
"renderCount": 20,
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"referenceImage": "bakedVertexAnimationDOF.png"
},
{
"title": "Baked Vertex Animation with Volumetric Light Scattering Post Process",
"playgroundId": "#1LF9GK#3",
"renderCount": 20,
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"referenceImage": "bakedVertexAnimationVLS.png"
},
{
Expand Down Expand Up @@ -2613,8 +2595,6 @@
{
"title": "PBR Debug Modes",
"playgroundId": "#2FDQT5#2300",
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"referenceImage": "PBR-Debug-Modes.png"
},
{
Expand All @@ -2634,8 +2614,6 @@
{
"title": "MeshDebugPluginMaterial",
"playgroundId": "#TFDNZI#2",
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"referenceImage": "MeshDebugPluginMaterial.png"
},
{
Expand Down Expand Up @@ -2742,9 +2720,9 @@
{
"title": "sphere-with-custom-shader-to-display-wireframe-using-glow-layer",
"playgroundId": "#Y05E2C#6",
"excludedGraphicsApis": ["OpenGL"],
"reason": "OpenGL: pixel diff out of tolerance (90900 px) -- likely glow-layer + custom-shader interaction differs from D3D11. Tracked for OpenGL backend follow-up.",
"renderCount": 5,
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"referenceImage": "sphere-with-custom-shader-to-display-wireframe-using-glow-layer.png"
},
{
Expand Down Expand Up @@ -3935,15 +3913,11 @@
{
"title": "OpenPBR Fuzz Weight vs Fuzz Roughness - Analytic Lights",
"playgroundId": "#GRQHVV#112",
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"referenceImage": "OpenPBR-Fuzz-Weight-vs-Fuzz-Roughness---Analytic-Lights.png"
},
{
"title": "OpenPBR Fuzz Weight vs Coat Weight with Normal Maps - Analytic Lights",
"playgroundId": "#GRQHVV#109",
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"referenceImage": "OpenPBR-Fuzz-Weight-vs-Coat-Weight-with-Normal-Maps---Analytic-Lights.png"
},
{
Expand Down Expand Up @@ -4047,8 +4021,6 @@
{
"title": "OpenPBR Transmission Dispersion VS IOR - Analytic Lights",
"playgroundId": "#GRQHVV#142",
"excludeFromAutomaticTesting": true,
"reason": "Test crashes or hangs on Babylon Native",
"referenceImage": "OpenPBR-Transmission-Dispersion-VS-IOR---Analytic-Lights.png"
},
{
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ FetchContent_Declare(metal-cpp
EXCLUDE_FROM_ALL)
FetchContent_Declare(SPIRV-Cross
GIT_REPOSITORY https://github.com/BabylonJS/SPIRV-Cross.git
GIT_TAG 0e1654748e9e54b5469fb0fbc1c715b96fa06f8f
GIT_TAG 866e5edcc3407997a3ed62f3edf492f91bcb2629
Comment thread
bkaradzic-microsoft marked this conversation as resolved.
EXCLUDE_FROM_ALL)

# --------------------------------------------------
Expand Down
3 changes: 3 additions & 0 deletions Plugins/ExternalTexture/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ set(SOURCES

add_library(ExternalTexture ${SOURCES})
warnings_as_errors(ExternalTexture)
if(GRAPHICS_API STREQUAL "OpenGL" AND MSVC)
target_compile_options(ExternalTexture PRIVATE /wd4702)
endif()

target_include_directories(ExternalTexture
PUBLIC "Include")
Expand Down
Loading