Skip to content

Update to latest bgfx/bx/bimg#1618

Merged
SergioRZMasson merged 16 commits into
BabylonJS:masterfrom
SergioRZMasson:sergio/update-bgfx-cmake
Mar 5, 2026
Merged

Update to latest bgfx/bx/bimg#1618
SergioRZMasson merged 16 commits into
BabylonJS:masterfrom
SergioRZMasson:sergio/update-bgfx-cmake

Conversation

@SergioRZMasson

Copy link
Copy Markdown
Contributor

Updated to latest version of bgfx/bx/bimg. This must wait for bgfx.cmake PR to be merged.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s bgfx/bx/bimg integration to align with newer upstream changes, including build-system adjustments and shader/callback compatibility updates.

Changes:

  • Update Direct3D embedded shader naming from *_dx11 to *_dxbc (CMake shader generation + checked-in shader headers).
  • Extend D3D11 external texture format table to match new bgfx TextureFormat entries.
  • Align BgfxCallback::screenShot signature with the updated bgfx callback interface and adjust dependency build flags/definitions.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Polyfills/Canvas/shaderc.cmake Updates shaderc BIN2C symbol suffix for D3D to dxbc.
Polyfills/Canvas/Source/Shaders/dx11/vs_nanovg_fill.h Renames embedded shader byte array symbol to *_dxbc.
Polyfills/Canvas/Source/Shaders/dx11/vs_fspass.h Renames embedded shader byte array symbol to *_dxbc.
Polyfills/Canvas/Source/Shaders/dx11/fs_nanovg_fill.h Renames embedded shader byte array symbol to *_dxbc.
Polyfills/Canvas/Source/Shaders/dx11/fs_gaussblur.h Renames embedded shader byte array symbol to *_dxbc.
Polyfills/Canvas/Source/Shaders/dx11/fs_boxblur.h Renames embedded shader byte array symbol to *_dxbc.
Plugins/ExternalTexture/Source/ExternalTexture_D3D11.cpp Adds new format slots (EAC*) to keep the DXGI mapping table aligned with bgfx’s format enum count.
Dependencies/CMakeLists.txt Adds new bgfx platform-support defines and MSVC bx compile options.
Core/Graphics/Source/BgfxCallback.cpp Updates screenShot implementation signature to match bgfx.
Core/Graphics/InternalInclude/Babylon/Graphics/BgfxCallback.h Updates screenShot override signature to match bgfx.
CMakeLists.txt Changes the bgfx.cmake FetchContent repository and pinned commit.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CMakeLists.txt Outdated
Comment thread Dependencies/CMakeLists.txt

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Core/Graphics/Source/BgfxCallback.cpp
Comment thread .github/jobs/win32.yml
Comment thread .github/jobs/win32.yml
Comment thread .github/jobs/win32.yml
Comment thread Core/Graphics/Source/BgfxCallback.cpp
@SergioRZMasson SergioRZMasson merged commit a3264cf into BabylonJS:master Mar 5, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants