Update to latest bgfx/bx/bimg#1618
Merged
SergioRZMasson merged 16 commits intoMar 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the project’s bgfx/bx/bimg integration to align with newer upstream changes, including build-system adjustments and shader/callback compatibility updates.
Changes:
- Update Direct3D embedded shader naming from
*_dx11to*_dxbc(CMake shader generation + checked-in shader headers). - Extend D3D11 external texture format table to match new bgfx
TextureFormatentries. - Align
BgfxCallback::screenShotsignature with the updated bgfx callback interface and adjust dependency build flags/definitions.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Polyfills/Canvas/shaderc.cmake | Updates shaderc BIN2C symbol suffix for D3D to dxbc. |
| Polyfills/Canvas/Source/Shaders/dx11/vs_nanovg_fill.h | Renames embedded shader byte array symbol to *_dxbc. |
| Polyfills/Canvas/Source/Shaders/dx11/vs_fspass.h | Renames embedded shader byte array symbol to *_dxbc. |
| Polyfills/Canvas/Source/Shaders/dx11/fs_nanovg_fill.h | Renames embedded shader byte array symbol to *_dxbc. |
| Polyfills/Canvas/Source/Shaders/dx11/fs_gaussblur.h | Renames embedded shader byte array symbol to *_dxbc. |
| Polyfills/Canvas/Source/Shaders/dx11/fs_boxblur.h | Renames embedded shader byte array symbol to *_dxbc. |
| Plugins/ExternalTexture/Source/ExternalTexture_D3D11.cpp | Adds new format slots (EAC*) to keep the DXGI mapping table aligned with bgfx’s format enum count. |
| Dependencies/CMakeLists.txt | Adds new bgfx platform-support defines and MSVC bx compile options. |
| Core/Graphics/Source/BgfxCallback.cpp | Updates screenShot implementation signature to match bgfx. |
| Core/Graphics/InternalInclude/Babylon/Graphics/BgfxCallback.h | Updates screenShot override signature to match bgfx. |
| CMakeLists.txt | Changes the bgfx.cmake FetchContent repository and pinned commit. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…breaking validation tests
…ZMasson/BabylonNative into sergio/update-bgfx-cmake
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bghgary
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to latest version of bgfx/bx/bimg. This must wait for bgfx.cmake PR to be merged.