Use texelFetch/textureLoad for WebGL2/WGSL by noname0310 · Pull Request #17811 · BabylonJS/Babylon.js

noname0310 · 2026-02-03T14:13:06Z

This PR replaces texture2D and texture with texelFetch and textureLoad.

This allows us to reduce the number of uniform variables by one when using Bone and VAT in WebGL2 and WebGPU,
while also simplifying the code.

If you feel this optimization is too aggressive or unnecessary, please share your thoughts.

sebavan

This is really nice !!! I would be in favor of keeping the uniforms in both cases to prevent the extra cpu usage of the checks and such everyframe.

The conditionnal part in the shader coud be #ifdef WEBGL1 ? so that soon-ish we could get rid of it alltogether :-)

Love the focus on perf here

noname0310 · 2026-02-03T23:19:11Z

I have reflected all the requested changes. 😀

noname0310 · 2026-02-04T15:03:29Z

@sebavan I want to see if it passes CI testing, can I run the pipeline...?

deltakosh

Excellent!

deltakosh · 2026-02-04T16:22:55Z

/azurepipelines run

azure-pipelines · 2026-02-04T16:23:07Z

Azure Pipelines successfully started running 1 pipeline(s).

bjsplat · 2026-02-04T16:24:29Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2026-02-04T16:39:22Z

Snapshot stored with reference name:
refs/pull/17811/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17811/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17811/merge/index.html#WGZLGJ#4600

Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves):

https://playground.babylonjs.com/?snapshot=refs/pull/17811/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/17811/merge
https://gui.babylonjs.com/?snapshot=refs/pull/17811/merge
https://nme.babylonjs.com/?snapshot=refs/pull/17811/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17811/merge#BCU1XR#0

If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools.

bjsplat · 2026-02-04T16:43:14Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17811/merge/testResults/interactionplaywright/index.html

bjsplat · 2026-02-04T16:46:10Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17811/merge/testResults/devhostplaywright/index.html

bjsplat · 2026-02-04T16:53:39Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17811/merge/testResults/webgl2playwright/index.html

bjsplat · 2026-02-04T17:19:31Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17811/merge/testResults/webgpuplaywright/index.html

sebavan · 2026-02-04T18:48:32Z

/azurepipelines run

azure-pipelines · 2026-02-04T18:48:43Z

Azure Pipelines successfully started running 1 pipeline(s).

bjsplat · 2026-02-04T19:40:56Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17811/merge/testResults/interactionplaywright/index.html

bjsplat · 2026-02-04T19:47:09Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17811/merge/testResults/devhostplaywright/index.html

bjsplat · 2026-02-04T19:53:45Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17811/merge/testResults/webgl2playwright/index.html

bjsplat · 2026-02-04T20:38:31Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17811/merge/testResults/webgpuplaywright/index.html

noname0310 · 2026-02-05T09:54:17Z

@sebavan run CI again please 😭

sebavan · 2026-02-05T10:27:59Z

/azp run Best Regards, Sébastien VANDENBERGHE

…

On Thu, Feb 5, 2026 at 10:54 noname ***@***.***> wrote: *noname0310* left a comment (BabylonJS/Babylon.js#17811) <#17811 (comment)> @sebavan <https://github.com/sebavan> run CI again please 😭 — Reply to this email directly, view it on GitHub <#17811 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD7CGPKPU4ZLGOAROZYWHRD4KMHN7AVCNFSM6AAAAACT2MIDVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQNJSGQYDKOJYHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

azure-pipelines · 2026-02-05T10:28:05Z

Command 'run Best' is not supported by Azure Pipelines. Supported commands help: Get descriptions, examples and documentation about supported commands Example: help "command_name" list: List all pipelines for this repository using a comment. Example: "list" run: Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run. Example: "run" or "run pipeline_name, pipeline_name, pipeline_name" where: Report back the Azure DevOps orgs that are related to this repository and org Example: "where" See additional documentation.

sebavan · 2026-02-05T17:16:49Z

/azp run

azure-pipelines · 2026-02-05T17:16:59Z

Azure Pipelines successfully started running 1 pipeline(s).

bjsplat · 2026-02-05T17:37:32Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17811/merge/testResults/interactionplaywright/index.html

bjsplat · 2026-02-05T17:47:52Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17811/merge/testResults/webgpuplaywright/index.html

bjsplat · 2026-02-05T17:50:14Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17811/merge/testResults/webgl2playwright/index.html

bjsplat · 2026-02-05T18:02:30Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17811/merge/testResults/devhostplaywright/index.html

sebavan · 2026-02-05T18:34:42Z

@noname0310 consider it merged, I am fixing the native part on the side

@noname0310

supercedes #17811 to merge it Thanks a ton @noname0310 --------- Co-authored-by: noname0310 <hjnam2014@gmail.com>

sebavan · 2026-02-05T20:32:30Z

@noname0310 it has been merged, only the thin instances to go :-) and I ll merge the doc

noname0310 added 2 commits February 3, 2026 23:09

Use texelFetch/textureLoad for WebGL2/WGSL

3254b20

forgot to save file

774159a

sebavan requested changes Feb 3, 2026

View reviewed changes

Comment thread packages/dev/core/src/BakedVertexAnimation/bakedVertexAnimationManager.ts Outdated

Comment thread packages/dev/core/src/Lights/Shadows/shadowGenerator.ts

Comment thread packages/dev/core/src/Materials/materialHelper.functions.ts Outdated

sebavan requested review from Popov72 and deltakosh February 3, 2026 16:16

Popov72 reviewed Feb 3, 2026

View reviewed changes

Comment thread packages/dev/core/src/ShadersWGSL/ShadersInclude/bakedVertexAnimationDeclaration.fx Outdated

Comment thread packages/dev/core/src/ShadersWGSL/ShadersInclude/bonesDeclaration.fx Outdated

noname0310 added 2 commits February 4, 2026 08:07

revert conditional binding

91af014

Remove unused WGSL uniform comments

bae53a6

Popov72 approved these changes Feb 4, 2026

View reviewed changes

deltakosh approved these changes Feb 4, 2026

View reviewed changes

deltakosh enabled auto-merge (squash) February 4, 2026 16:22

Fix textureLoad parentheses in WGSL shader

f33ac30

auto-merge was automatically disabled February 4, 2026 18:28
Head branch was pushed to by a user without write access

sebavan approved these changes Feb 4, 2026

View reviewed changes

sebavan enabled auto-merge (squash) February 4, 2026 18:51

fix textureLoad param

3c88319

auto-merge was automatically disabled February 5, 2026 01:55
Head branch was pushed to by a user without write access

CedricGuillemet mentioned this pull request Feb 5, 2026

Use texelFetch/textureLoad BabylonJS/BabylonNative#1599

Open

sebavan mentioned this pull request Feb 5, 2026

Use texelFetch/textureLoad for WebGL2/WGSL #17829

Merged

sebavan closed this Feb 5, 2026

sebavan added a commit that referenced this pull request Feb 5, 2026

Use texelFetch/textureLoad for WebGL2/WGSL (#17829)

196d9fd

supercedes #17811 to merge it Thanks a ton @noname0310 --------- Co-authored-by: noname0310 <hjnam2014@gmail.com>

Uh oh!

Conversation

noname0310 commented Feb 3, 2026

Uh oh!

sebavan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

noname0310 commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

noname0310 commented Feb 4, 2026

Uh oh!

deltakosh left a comment

Choose a reason for hiding this comment

Uh oh!

deltakosh commented Feb 4, 2026

Uh oh!

azure-pipelines Bot commented Feb 4, 2026

Uh oh!

bjsplat commented Feb 4, 2026

Uh oh!

bjsplat commented Feb 4, 2026

Uh oh!

bjsplat commented Feb 4, 2026

Uh oh!

bjsplat commented Feb 4, 2026

Uh oh!

bjsplat commented Feb 4, 2026

Uh oh!

bjsplat commented Feb 4, 2026

Uh oh!

sebavan commented Feb 4, 2026

Uh oh!

azure-pipelines Bot commented Feb 4, 2026

Uh oh!

bjsplat commented Feb 4, 2026

Uh oh!

bjsplat commented Feb 4, 2026

Uh oh!

bjsplat commented Feb 4, 2026

Uh oh!

bjsplat commented Feb 4, 2026

Uh oh!

noname0310 commented Feb 5, 2026

Uh oh!

sebavan commented Feb 5, 2026 via email

Uh oh!

azure-pipelines Bot commented Feb 5, 2026

Uh oh!

sebavan commented Feb 5, 2026

Uh oh!

azure-pipelines Bot commented Feb 5, 2026

Uh oh!

bjsplat commented Feb 5, 2026

Uh oh!

bjsplat commented Feb 5, 2026

Uh oh!

bjsplat commented Feb 5, 2026

Uh oh!

bjsplat commented Feb 5, 2026

Uh oh!

sebavan commented Feb 5, 2026

Uh oh!

sebavan commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

noname0310 commented Feb 3, 2026 •

edited

Loading