Skip to content

Fluent: Add accordion primitive #16789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 23, 2025

Conversation

ryantrem
Copy link
Member

This is a simple accordion primitive wrapper on top of the Fluent accordion.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 23, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@deltakosh deltakosh enabled auto-merge (squash) June 23, 2025 19:18
@bjsplat
Copy link
Collaborator

bjsplat commented Jun 23, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 23, 2025

Graph tools CI has failed you can find the test results at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16789/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 23, 2025

Building or testing the playground has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16789/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 23, 2025

Building or testing the sandbox has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16789/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 23, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 23, 2025

Graph tools CI has failed you can find the test results at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16789/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 23, 2025

Building or testing the playground has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16789/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 23, 2025

Building or testing the sandbox has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16789/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 23, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 23, 2025

Building or testing the playground has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16789/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 23, 2025

Graph tools CI has failed you can find the test results at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16789/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 23, 2025

Building or testing the sandbox has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16789/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 23, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 23, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 23, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 23, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16789/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 23, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16789/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16789/merge/?snapshot=refs/pull/16789/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 23, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 23, 2025

@deltakosh deltakosh merged commit 4d5a38a into BabylonJS:master Jun 23, 2025
19 of 20 checks passed
@ryantrem ryantrem added the tools label Jun 23, 2025
alexchuber pushed a commit to alexchuber/Babylon.js that referenced this pull request Jun 24, 2025
This is a simple accordion primitive wrapper on top of the Fluent
accordion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants