Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, mainly React #16461

Merged
merged 9 commits into from
Apr 9, 2025

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Apr 8, 2025

This PR updates the dependencies of the main repo. The main update here is the update of React to 18.
This is needed as the first step towards moving the documentation to the main repository.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

Graph tools CI has failed you can find the test results at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16461/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

Building or testing the playground has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16461/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16461/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16461/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16461/merge/?snapshot=refs/pull/16461/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

Reviewer - this PR has made changes to one or more package.json files.

@RaananW
Copy link
Member Author

RaananW commented Apr 8, 2025

Reverted webpack back to 5.98.X because of this issue - webpack/webpack#19394 , will update when the issue os resolved.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

Graph tools CI has failed you can find the test results at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16461/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

Building or testing the sandbox has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16461/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16461/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16461/merge/?snapshot=refs/pull/16461/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

Building or testing the sandbox has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16461/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16461/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16461/merge/?snapshot=refs/pull/16461/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

@RaananW
Copy link
Member Author

RaananW commented Apr 8, 2025

A small issue to resolve with the sandbox inspector select feature, will resolve this first thing tomorrow.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16461/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16461/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16461/merge/?snapshot=refs/pull/16461/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 9, 2025

@RaananW RaananW merged commit f0547a6 into BabylonJS:master Apr 9, 2025
19 checks passed
@RaananW RaananW deleted the updateDependenciesAndReact branch April 9, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants