Add shadow support #16459
Add shadow support #16459
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16459/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16459/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16459/merge#BCU1XR#0 |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
1 similar comment
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
I will be happy to help with the build issue, if you have any questions about it |
|
Thanks, I think it is just because I needed to had |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
Reviewer - this PR has made changes to one or more package.json files. |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
|
@RaananW The CI is still in error but I don't think I've changed anything. Are they just flaky test ? |
|
Reviewer - this PR has made changes to one or more package.json files. |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
Reviewer - this PR has made changes to one or more package.json files. |
i'll wait for this run and check what's happening POST-EDIT - seems to be green now. I will keep this PR in mind if it fails again. |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
In the viewer, add the support for :
normal,highFor now, ibl shadows are dissabled for meshes that have animations in WebGPU even if the animation is paused as there is some issues.
Still in draft are there is still issues in WebGPU mode.
The auto shadow selection will come in another PR.
The placement of the light will come in another PR.