-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewer Configurator: Add json output + save/load snippet #16447
Conversation
… not be properties
Change back ordering in reset (camera must be after animation since animation also reframes the camera without overrides)
Add more comments
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16447/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16447/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16447/merge#BCU1XR#0 |
Visualization tests for WebGPU |
WebGL2 visualization test reporter: |
packages/tools/viewer-configurator/src/components/configurator/configurator.tsx
Outdated
Show resolved
Hide resolved
Visualization tests for WebGPU |
WebGL2 visualization test reporter: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed the JSON creation offline. To meet formatting requirements, we'd need to do some extra regex manipulation on top of a JSON.stringify(). Seeing as this is just in the configurator, manual formatting is fine.
This change introduces two new configurator features:
The ability to save/load the current state (to/from snippet server). See https://forum.babylonjs.com/t/babylon-viewer-v2/54317/65


The ability to output to json, which can in turn be passed into any of the Viewer layers as the

ViewerOptions
(making the configurator useful even if you aren't using the html layer).Changes to enable this:
initialConfiguredState
touseConfiguration
(comes from the loaded config/options).useConfiguration
.ViewerOptions
) to snippet server and encode into the url like other Babylon tools.ConfigureCustomViewerElement
to determine the initial state of the Viewer within the Configurator.Also fixed a small bug where environment intensity and rotation were not output if the skybox was disabled.