Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispose managed material plugins on feature destruction #16439

Merged
merged 2 commits into from
Apr 2, 2025

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Apr 2, 2025

Ensure proper disposal of managed material plugins when the feature is destroyed to prevent memory leaks.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 2, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@RaananW RaananW added the bug label Apr 2, 2025
@RaananW RaananW requested a review from sebavan April 2, 2025 19:28
@bjsplat
Copy link
Collaborator

bjsplat commented Apr 2, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@sebavan sebavan enabled auto-merge (squash) April 2, 2025 19:49
@bjsplat
Copy link
Collaborator

bjsplat commented Apr 2, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 2, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 2, 2025

@sebavan sebavan merged commit 29ef256 into BabylonJS:master Apr 2, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants