Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SH fix SPZ+PLY #16433

Merged
merged 9 commits into from
Apr 8, 2025
Merged

SH fix SPZ+PLY #16433

merged 9 commits into from
Apr 8, 2025

Conversation

CedricGuillemet
Copy link
Contributor

@CedricGuillemet CedricGuillemet commented Apr 1, 2025 •
edited
Loading

  • Fix SH loading with .PLY
  • Fix SH computation in shader
  • More consistent coordinate system between .ply, compressed.ply & spz
  • Validation tests + test assets

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 1, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 1, 2025

Snapshot stored with reference name:
refs/pull/16433/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16433/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16433/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/16433/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/16433/merge
https://gui.babylonjs.com/?snapshot=refs/pull/16433/merge
https://nme.babylonjs.com/?snapshot=refs/pull/16433/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/16433/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 1, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16433/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 1, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16433/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 3, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16433/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 3, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16433/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 3, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 3, 2025

Snapshot stored with reference name:
refs/pull/16433/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16433/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16433/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/16433/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/16433/merge
https://gui.babylonjs.com/?snapshot=refs/pull/16433/merge
https://nme.babylonjs.com/?snapshot=refs/pull/16433/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/16433/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 3, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16433/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 3, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16433/merge/testResults/webgl2playwright/index.html

@CedricGuillemet CedricGuillemet marked this pull request as ready for review April 7, 2025 08:35
@bjsplat
Copy link
Collaborator

bjsplat commented Apr 7, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16433/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 7, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16433/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 7, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16433/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 7, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16433/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 7, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16433/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 7, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16433/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 7, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16433/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 7, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16433/merge/testResults/webgl2playwright/index.html

1 similar comment
@bjsplat
Copy link
Collaborator

bjsplat commented Apr 7, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16433/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 7, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16433/merge/testResults/webgpuplaywright/index.html

@CedricGuillemet CedricGuillemet marked this pull request as draft April 8, 2025 12:41
@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16433/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16433/merge/testResults/webgl2playwright/index.html

@CedricGuillemet CedricGuillemet marked this pull request as ready for review April 8, 2025 13:55
@CedricGuillemet CedricGuillemet merged commit eef266d into BabylonJS:master Apr 8, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Popov72 Popov72 Popov72 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CedricGuillemet @bjsplat @Popov72