Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pure SVG by img svg for perf #16404

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Conversation

deltakosh
Copy link
Contributor

No description provided.

@deltakosh deltakosh enabled auto-merge (squash) March 25, 2025 17:31
@bjsplat
Copy link
Collaborator

bjsplat commented Mar 25, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 25, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 25, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16404/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 25, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16404/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16404/merge/?snapshot=refs/pull/16404/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 25, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 25, 2025

@deltakosh deltakosh merged commit 9841c65 into master Mar 25, 2025
17 of 18 checks passed
@deltakosh deltakosh deleted the fix-node-editor-svg-slow branch March 25, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants