Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the audio engine unmute button relative to its parent element #16378

Merged

Conversation

docEdub
Copy link
Contributor

@docEdub docEdub commented Mar 21, 2025

The position of the audio engine unmute button in the playground is in the top left corner of the code pane instead of the render area.

This change fixes the issue by positioning the button relative to the parent element instead of absolute top left.

The position of the audio engine unmute button in the playground is in the top left corner of the code pane instead of the render area.

This change fixes the issue by positioning the button relative to the parent element instead of absolute top left.
@bjsplat
Copy link
Collaborator

bjsplat commented Mar 21, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 21, 2025

@docEdub docEdub marked this pull request as ready for review March 21, 2025 05:10
@docEdub docEdub enabled auto-merge (squash) March 21, 2025 05:11
@bjsplat
Copy link
Collaborator

bjsplat commented Mar 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 21, 2025

@docEdub docEdub requested a review from RaananW March 21, 2025 07:02
@docEdub docEdub merged commit 0a7437f into BabylonJS:master Mar 21, 2025
16 checks passed
@docEdub docEdub deleted the 250321-fix-playground-unmute-button-position branch April 7, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants