Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node port colors when optional (NME, NGE, NRGE) #16366

Merged
merged 6 commits into from
Mar 19, 2025
Merged

Conversation

deltakosh
Copy link
Contributor

I had to move from img to svg to be able to color code but that was a change I wanted to do any way...That’s my TED Talk, thanks for coming.

@deltakosh deltakosh added nme Node Material Editor nge nrge node render graph editor labels Mar 19, 2025
@deltakosh deltakosh changed the title Svg node port Update node port colors when optional (NME, NGE, NRGE) Mar 19, 2025
@deltakosh deltakosh enabled auto-merge (squash) March 19, 2025 20:19
@bjsplat
Copy link
Collaborator

bjsplat commented Mar 19, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 19, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 19, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@deltakosh
Copy link
Contributor Author

FYI @AmoebaChant for the port to SFE

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 19, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 19, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16366/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 19, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16366/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16366/merge/?snapshot=refs/pull/16366/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 19, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 19, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 19, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16366/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 19, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16366/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16366/merge/?snapshot=refs/pull/16366/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 19, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 19, 2025

@deltakosh deltakosh merged commit e2cc719 into master Mar 19, 2025
17 of 18 checks passed
@deltakosh deltakosh deleted the svg-node-port branch March 19, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature nge nme Node Material Editor nrge node render graph editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants