Add audio engine v2 unmute UI #16348
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR adds an unmute UI button for the new audio engine v2 to replicate the functionality of the old audio engine's button.
- Introduces a new class to create and manage the unmute UI button in webAudioUnmuteUI.ts
- Updates the webAudioEngine.ts file to instantiate and dispose of the unmute UI appropriately
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/dev/core/src/AudioV2/webAudio/webAudioUnmuteUI.ts | New UI implementation for unmute functionality with a button and style element. |
| packages/dev/core/src/AudioV2/webAudio/webAudioEngine.ts | Integration of the unmute UI into the engine lifecycle. |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16348/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16348/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16348/merge#BCU1XR#0 |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
Co-authored-by: Raanan Weber <raananw+github@gmail.com>
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
Adds an unmute UI button for audio engine v2.
The button is the same as the old audio engine's button to make it easier to eventually reimplement the old audio engine using the new audio engine.