Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebXR visualization tests and improve test utility functions #16332

Merged
merged 2 commits into from
Mar 17, 2025

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Mar 17, 2025

highly inspired by #16204 of @simonedevit,
introducing a new playwright project to test webxr scenes. Using IWER (as the original PR) and not an extension, as browserstack does not support installing extensions as part of the test run.

The idea here is to not change anything in core classes and other tests. The only thing changed is the new testing mechanism. If we want to generate interaction in XR we should do it in the playground itself.

This is used to make sure WebXR scenes render correctly and is not meant to test interaction. This should be done differently, and not part of the vis-tests suite.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 17, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 17, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 17, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16332/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 17, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16332/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16332/merge/?snapshot=refs/pull/16332/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 17, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 17, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 17, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16332/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 17, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16332/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16332/merge/?snapshot=refs/pull/16332/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 17, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 17, 2025

@RaananW RaananW merged commit 27b6373 into BabylonJS:master Mar 17, 2025
18 checks passed
@RaananW RaananW deleted the webxrTestingBase branch March 17, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants