Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Havok shape memory leak #16331

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Conversation

noname0310
Copy link
Contributor

In the Havok Plugin class, we are not doing a delete after a set on the shape map.

disposeShape seems like the right place to call delete.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 15, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 15, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 15, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 15, 2025

@RaananW RaananW requested a review from CedricGuillemet March 17, 2025 12:54
@CedricGuillemet
Copy link
Contributor

Good catch! Thanks!

@RaananW RaananW merged commit be46d57 into BabylonJS:master Mar 17, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants