Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose OBJFileLoader options to scene loader APIs #16322

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

ryantrem
Copy link
Member

This is a small change that exposes the existing ObjFileLoader options through the new scene loader functions. The focus at the time was glTF and this just wasn't on the radar, but there is a real use case for it now.

  • Allow a subset of options to be passed to OBJFileLoader. Any that are missing will get the default. This is fully backward compatible with the existing API.
  • Plumb OBJFileLoader options through the dynamic loader factory (same as other loader plugins).

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 14, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@sebavan sebavan enabled auto-merge (squash) March 14, 2025 17:25
@bjsplat
Copy link
Collaborator

bjsplat commented Mar 14, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 14, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 14, 2025

@sebavan sebavan merged commit 625c9ce into BabylonJS:master Mar 14, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants