Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer and configurator tiny fixes #16321

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

ryantrem
Copy link
Member

  1. The default viewer annotation UI does not show up if the innerHTML is white space only (e.g. code formatting). It seems this is just how slots work with html custom elements, but this is not how we want the viewer annotations to work. This change just sets the innerHTML to empty string if it is only white space so the default annotation UI still shows up (e.g. it is not replaced by html white space).
  2. Changed the help icon in the Viewer Configurator based on bug bash feedback.
    image

Replace help icon
@ryantrem ryantrem enabled auto-merge (squash) March 14, 2025 16:24
@bjsplat
Copy link
Collaborator

bjsplat commented Mar 14, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 14, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 14, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 14, 2025

@ryantrem ryantrem merged commit e0dbdb3 into BabylonJS:master Mar 14, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants