Fix lattice ejecting vertices too early #16316
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16316/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16316/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16316/merge#BCU1XR#0 |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
| * @param epsilon (default = Number.EPSILON) | ||
| * @returns true if the number is between min and max values | ||
| */ | ||
| export function OutsideRange(num: number, min: number, max: number, epsilon: number = 1.401298e-45): boolean { |
There was a problem hiding this comment.
Why not using Number.EPSILON instead of 1.401298e-45? Also, Chromes give me 2.220446049250313e-16 for Number.EPSILON:
[...]
Looking at existing code above, I can see that 1.401298e-45 is the default epsilon value we use elsewhere, so I think you should simply remove the reference to Number.EPSILON from the function doc.
No description provided.