Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance matrix validation and type transformation features #16301

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Mar 13, 2025

Round the last column components of the matrix for improved validation checks, add a type transformer to facilitate value transformations in RichType, and correct a typo in the isDisabled property while introducing a lastValue for debugging purposes.

Also introducing a multi-type connection transformer. The idea here is that it is possible that a data input of specific type will be connected to a data input connection of another type. We have specific blocks for that, but in some cases, like quaternion and vector4, it can be supported out of the box directly in the connection. This PR adds a type transformer to quaternion input/output data connections. If a data connection of type quaternion is connected to a vector4, it will be converted to the right type.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 13, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 13, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 13, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 13, 2025

@RaananW RaananW merged commit 0412cd1 into BabylonJS:master Mar 13, 2025
16 checks passed
@RaananW RaananW deleted the roundingMatrixFun branch March 13, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants