Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XR] make sure setTarget works as expected in WebXR. #13553

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Feb 22, 2023

This will calculate the new rotation in the Y axis and apply it to the already-existing rotation to avoid losing the up-direction when using setTarget.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 22, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 22, 2023

@RaananW RaananW merged commit 14f58e1 into BabylonJS:master Feb 22, 2023
@RaananW RaananW deleted the setTargetWebXR branch February 22, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants