PBR: Fix realtime filtering for refraction #13540
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://forum.babylonjs.com/t/es6-import-of-babylonjs-core-ignoring-side-effects-required-for-khr-materials-transmission/38198
Realtime filtering can only work if the refraction texture is a cube (the
radiance
function is expecting aCubeSampler
). So, we should disable realtime filtering when the refraction texture is a 2D texture.