Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBR: Fix realtime filtering for refraction #13540

Merged
merged 1 commit into from
Feb 15, 2023
Merged

PBR: Fix realtime filtering for refraction #13540

merged 1 commit into from
Feb 15, 2023

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Feb 15, 2023

See https://forum.babylonjs.com/t/es6-import-of-babylonjs-core-ignoring-side-effects-required-for-khr-materials-transmission/38198

Realtime filtering can only work if the refraction texture is a cube (the radiance function is expecting a CubeSampler). So, we should disable realtime filtering when the refraction texture is a 2D texture.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 15, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@RaananW RaananW enabled auto-merge (squash) February 15, 2023 12:41
@bjsplat
Copy link
Collaborator

bjsplat commented Feb 15, 2023

@RaananW RaananW merged commit 655c80b into master Feb 15, 2023
@RaananW RaananW deleted the Popov72-patch-1 branch February 15, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants