Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomMaterial: Don't prevent support for uniform arrays #13519

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Feb 9, 2023

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 9, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 9, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@Popov72 Popov72 marked this pull request as ready for review February 9, 2023 10:52
Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand this correctly, it removes any array reference ([123]) from the string passed?

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 9, 2023

@Popov72
Copy link
Contributor Author

Popov72 commented Feb 9, 2023

If I understand this correctly, it removes any array reference ([123]) from the string passed?

Yes indeed. That part of the code only needs the name of the uniform, not the whole declaration.

@RaananW RaananW merged commit 9c776c5 into master Feb 9, 2023
@RaananW RaananW deleted the Popov72-patch-1 branch February 9, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants