Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NME : Use flag IgnoreTexturesAtLoadTime in ReflectionTextureBaseBlock #13409

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

GMM-Monumento
Copy link
Contributor

@GMM-Monumento GMM-Monumento commented Jan 5, 2023

When creating ReflectionTextureBaseBlock from a JSON NME material, if the flag NodeMaterial.IgnoreTexturesAtLoadTime is activated, this pull request prevents texture loading.

This new behavior is similar to the ones already existing in TextureBlock, ImageSourceBlock or TriPlanarBlock.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 5, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 5, 2023

@RaananW RaananW merged commit df0d918 into BabylonJS:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants