Cache loaded dom images on Image class so the playground-editor doesn't have to reload them often

[carolhmj]

Without the change:

With the change:

[RaananW]

Is the data being disposed when the GUI is disposed?

[sebavan]

I am not sure this should be part of the Image class, could the cache be moved in the editor as it looks dedicated for it ?

[carolhmj]

I am not sure this should be part of the Image class, could the cache be moved in the editor as it looks dedicated for it ?

@sebavan this behavior isn't totally exclusive to the editor, as this would happen in any case where the control is repeatedly cleared and added to the parent. For example, this Playground: https://playground.babylonjs.com/#F2SG3A#2

Behaves like this now:

But with the cache:

[RaananW]

My only comment is caching to a static object without clearing it when the image/scene/engine disposes. Not sure what would be the best dispose mechanism here, but it should be cleared for sure when the engine is disposed (otherwise it is technically a memory leak). Is it possible to dispose the data when an image is disposed?

[kircher1]

@carolhmj, would this also remove the duplicated image requests for grass.png in this playground? https://playground.babylonjs.com/#XCPP9Y#16922

[carolhmj]

@carolhmj, would this also remove the duplicated image requests for grass.png in this playground? https://playground.babylonjs.com/#XCPP9Y#16922

@kircher1 I tested and it does remove the duplication! I'm just going to move this to be a ADT level cache so it doesn't leak memory :)

[carolhmj]

Cache was moved to the ADT! @RaananW @sebavan @kircher1

The only caveat is that, since we need to know to which ADT the image belongs to cache it, caching will only occur if img.source is set AFTER it is added to a control.

[bjsplat]

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13388/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

[sebavan]

The only caveat is that, since we need to know to which ADT the image belongs to cache it, caching will only occur if img.source is set AFTER it is added to a control.

ohhh yeah right, I wonder how often we actually set it after knowing it is a ctor parameter ?

[RaananW]

LGTM. @sebavan - i'll let you merge it after your concerns are addressed.

[carolhmj]

@sebavan @RaananW updated to have the cache back as a static Image member, but we keep track of how many times that image is being used to clear it when it's not necessary anymore