Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NME: Fix reusing the same temporary variable name in TextureBlock #13335

Merged
merged 1 commit into from
Dec 8, 2022
Merged

NME: Fix reusing the same temporary variable name in TextureBlock #13335

merged 1 commit into from
Dec 8, 2022

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Dec 8, 2022

No description provided.

@Popov72 Popov72 added bug nme Node Material Editor labels Dec 8, 2022
@sebavan sebavan enabled auto-merge December 8, 2022 18:32
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/13335/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13335/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13335/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/13335/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13335/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13335/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13335/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/13335/merge#BCU1XR#0

@sebavan sebavan merged commit 70db330 into master Dec 8, 2022
@sebavan sebavan deleted the Popov72-patch-1 branch December 8, 2022 19:34
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@sebavan
Merge pull request #13335 from BabylonJS/Popov72-patch-1
2ad04bb 
NME: Fix reusing the same temporary variable name in TextureBlock
Former-commit-id: 47ebc51c2dbaaaaf9530f3f143db44ca4e9bd97f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
bug nme Node Material Editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Popov72 @sebavan