InputManager: Fix Order and Execution of onPrePointerObservable #13295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user on the forum had pointed out that there was an issue with how
onPrePointerObservable
was handling types and skipping foronPointerObservable
. After investigating the areas pointed out by the user and their proposed solutions, we were able to determine that there was an issue withonPrePointerObservable
and how it interacted withonPointerObservable
.This PR not only contains the proposed fixes but also changes the order that UP and TAP/DOUBLETAP are executed to reflect a similar order to how PointerEvents are processed (
pointerup
happens beforeclick
).Forum Link: https://forum.babylonjs.com/t/prepointerobservable-pointertap-fired-after-drag-when-skiponpointerobservable-true/35691/2