Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputManager: Fix Order and Execution of onPrePointerObservable #13295

Merged
merged 2 commits into from
Nov 29, 2022
Merged

InputManager: Fix Order and Execution of onPrePointerObservable #13295

merged 2 commits into from
Nov 29, 2022

Conversation

PolygonalSun
Copy link
Contributor

A user on the forum had pointed out that there was an issue with how onPrePointerObservable was handling types and skipping for onPointerObservable. After investigating the areas pointed out by the user and their proposed solutions, we were able to determine that there was an issue with onPrePointerObservable and how it interacted with onPointerObservable.

This PR not only contains the proposed fixes but also changes the order that UP and TAP/DOUBLETAP are executed to reflect a similar order to how PointerEvents are processed (pointerup happens before click).

Forum Link: https://forum.babylonjs.com/t/prepointerobservable-pointertap-fired-after-drag-when-skiponpointerobservable-true/35691/2

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@sebavan sebavan merged commit 55a3209 into BabylonJS:master Nov 29, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
InputManager: Fix Order and Execution of onPrePointerObservable
Former-commit-id: 86bdd8b480c5a7b3b97f4529da6fa4fb602f0e9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants