Cameras: Modified cameras to work under onPointerObservable #13293
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13293/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/13293/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/13293/merge#BCU1XR#0 |
|
Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
* Modified inputs to use onPointerObservable * Formatting * factored out picking check Former-commit-id: a2e085cc1a1ea08eb2395f1fbb52c436359baf86
A user on the forums recently found an issue related to
onPointerObservablewhere skipNextObservers weren't working as they used to. This issue was a side effect of an optimization make in support of Lazy Picking. This optimization would take all internal camera inputs and remove them from the user-facingonPointerObservable. This would cause the camera input observers to be inaccessible in the same way. This PR will add them back toonPointerObservablebut keep track of how many camera input observers have been added and require either user-defined observer as part of the criteria for picking.Forum Post: https://forum.babylonjs.com/t/no-longer-able-to-cancel-camera-inputs-with-new-oncamerainputobservable/35793