Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gizmo Release Drag #13237

Merged
merged 4 commits into from
Nov 15, 2022
Merged

Fix Gizmo Release Drag #13237

merged 4 commits into from
Nov 15, 2022

Conversation

CedricGuillemet
Copy link
Contributor

Fixes for :

https://forum.babylonjs.com/t/positiongizmo-does-not-respect-update-gizmo-position-to-match-attached-mesh/35673/3
Forward properties updateGizmoPositionToMatchAttachedMesh and updateGizmoRotationToMatchAttachedMesh to agregated gizmos. And uses gizmo rootmesh postion for rotation angle computation

https://forum.babylonjs.com/t/gizmomanager-releasedrag-cant-drag-anymore-after/35289
_activeDragButton was not reset in releaseDrag. so when calling that method, it was impossible to start a new drag operation after.

…nToMatchAttachedMesh to agregated gizmos

use gizmo rootmesh position for rotation when updateGizmoPositionToMatchAttachedMesh is false
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@sebavan sebavan changed the title Forum issues fix Fix Gizmo Release Drag Nov 14, 2022
@sebavan sebavan enabled auto-merge November 14, 2022 15:29
@sebavan sebavan merged commit ccb97c2 into BabylonJS:master Nov 15, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
Fix Gizmo Release Drag

Former-commit-id: 125682947b2a5b368b93b715cb524a343c68bd46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants