-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Gizmo Release Drag #13237
Fix Gizmo Release Drag #13237
Conversation
…nToMatchAttachedMesh to agregated gizmos use gizmo rootmesh position for rotation when updateGizmoPositionToMatchAttachedMesh is false
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13237/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/13237/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/13237/merge#BCU1XR#0 |
Fix Gizmo Release Drag Former-commit-id: 125682947b2a5b368b93b715cb524a343c68bd46
Fixes for :
https://forum.babylonjs.com/t/positiongizmo-does-not-respect-update-gizmo-position-to-match-attached-mesh/35673/3
Forward properties
updateGizmoPositionToMatchAttachedMesh
andupdateGizmoRotationToMatchAttachedMesh
to agregated gizmos. And uses gizmo rootmesh postion for rotation angle computationhttps://forum.babylonjs.com/t/gizmomanager-releasedrag-cant-drag-anymore-after/35289
_activeDragButton
was not reset inreleaseDrag
. so when calling that method, it was impossible to start a new drag operation after.