-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InputManager: Modify Picking to only happen with necessary scenarios #13145
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13145/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/13145/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/13145/merge#BCU1XR#0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the same feedback than Gary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the tests !!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor comments. LGTM
…13145) * lazy down * changed to break * Change to remove potential double pick * Add visual tests for callbacks/observables * Some PR Feedback * PR Feedback * Fix for Safari test * nits Former-commit-id: a3eb9040ae03757e550ebfc4292115d26a85f137
This PR modifies the picking code for UP and DOWN to only pick when there is a user scenario that requires it (user-defined observers in
onPointerObservable
, defined actions for an ActionManager, and assigned behaviors). Additionally, there are tests being added to verify that the InputManager callbacks and observable are functioning properly, as well as picking functionality. All camera pointer inputs will now connect to an internal observable_onCameraInputObservable