Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove new methods #13137

Merged
merged 5 commits into from
Oct 20, 2022
Merged

remove new methods #13137

merged 5 commits into from
Oct 20, 2022

Conversation

BabylonJSGuide
Copy link
Contributor

The recently added methods that have now been deleted, RotationQuaternionFromOntoToRef and RotationQuaternionFromOnto, turned out to be equivalent to the existing one FromUnitVectorsToRef so are not necessary.

Will any reference to them in What's New be automatically deleted?

@BabylonJSGuide
Copy link
Contributor Author

@RaananW please review

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@azure-pipelines
Copy link

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13137/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one question

@sebavan sebavan enabled auto-merge October 20, 2022 19:10
@sebavan sebavan merged commit 210ac59 into BabylonJS:master Oct 20, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
remove new methods

Former-commit-id: 91d504f3c801e14500aaa5db046dd4ddd54457e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants