Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading of GUIs with custom fonts and add font controls to InputText and InputPassword #13129

Merged
merged 5 commits into from
Oct 19, 2022
Merged

Fix loading of GUIs with custom fonts and add font controls to InputText and InputPassword #13129

merged 5 commits into from
Oct 19, 2022

Conversation

carolhmj
Copy link
Contributor

@carolhmj carolhmj commented Oct 19, 2022 •
edited
Loading

Fixes #13125

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/13129/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13129/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13129/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/13129/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13129/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13129/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13129/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/13129/merge#BCU1XR#0

@sebavan sebavan changed the title [GE] Fix loading of GUIs with custom fonts and add font controls to InputText and InputPassword Fix loading of GUIs with custom fonts and add font controls to InputText and InputPassword Oct 19, 2022
@sebavan sebavan merged commit 67eb0e3 into BabylonJS:master Oct 19, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@sebavan
Merge pull request #13129 from carolhmj/fixFontLoading
0afebbd 
Fix loading of GUIs with custom fonts and add font controls to InputText and InputPassword

Former-commit-id: f56819f1507cf2a0908a2ee701f169ab5313e784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Popov72 Popov72 Popov72 approved these changes

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
bug gui editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Text control parameters to containers missing them
3 participants
@carolhmj @Popov72 @sebavan