Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GUI json load. #13120

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Fix GUI json load. #13120

merged 2 commits into from
Oct 18, 2022

Conversation

carolhmj
Copy link
Contributor

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@azure-pipelines
Copy link

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13120/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@azure-pipelines
Copy link

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13120/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@azure-pipelines
Copy link

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13120/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@azure-pipelines
Copy link

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13120/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@sebavan
Copy link
Member

sebavan commented Oct 18, 2022

@carolhmj looks like this broke some tests ?

@carolhmj
Copy link
Contributor Author

@carolhmj looks like this broke some tests ?

woops I forgot to tell the tests to wait for a few frames before screenshot, this should be fixed now 🤣

@sebavan sebavan merged commit 8c664e1 into BabylonJS:master Oct 18, 2022
@carolhmj carolhmj deleted the fixGuiJsonLoad branch October 20, 2022 12:50
RaananW pushed a commit that referenced this pull request Dec 9, 2022
Fix GUI json load.

Former-commit-id: 63583e2798fa33aad2434c3e0885470eec3e76ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants