Fixed transform gizmos screen size #13079
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13079/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/13079/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/13079/merge#BCU1XR#0 |
* Fixed gizmos screen size * Fixed wrong gizmo direction * Fixed gizmo scale for rightHanded coordinates * Fixed review notes Former-commit-id: bf654c475ef60c0674aca39af142df2f870be641
Hi,
I noticed that gizmos do not correctly preserve the size on the screen.
You can notice that if the aspect ratio of the screen is big enough and you move a gizmo to the edge of the screen. It gets bigger. And this doesn't work at all with ORTHO-cameras.
I've fixed the math a little bit and added branching depending on whether the camera is PERSP or ORTHO
Before:
https://user-images.githubusercontent.com/2855321/194728765-276ae78a-4906-4c95-9ef9-6a4bae9d5501.mp4
After:
https://user-images.githubusercontent.com/2855321/194755033-bfe76baf-25d3-40a0-9795-f891941d6d51.mp4