Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize animation interpolate function #12945

Merged
merged 7 commits into from
Sep 7, 2022

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented Sep 3, 2022

Not 100% sure this actually helps since we are seeing weird results in the profile, but it is certainly easier to read.

@bghgary bghgary marked this pull request as draft September 3, 2022 01:01
@bghgary bghgary requested review from deltakosh and sebavan September 3, 2022 01:01
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@azure-pipelines
Copy link

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12945/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@azure-pipelines
Copy link

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12945/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

Copy link
Contributor

@deltakosh deltakosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what to review as the diff is all over the place but I spotted nothing wrong

@azure-pipelines
Copy link

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12945/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@azure-pipelines
Copy link

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12945/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@bghgary
Copy link
Contributor Author

bghgary commented Sep 6, 2022

Not sure what to review as the diff is all over the place but I spotted nothing wrong

If you hide whitespace changes, it will be much easier to read :-)

@azure-pipelines
Copy link

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12945/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@azure-pipelines
Copy link

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12945/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@azure-pipelines
Copy link

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12945/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@azure-pipelines
Copy link

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12945/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@bghgary bghgary marked this pull request as ready for review September 7, 2022 16:06
@sebavan sebavan enabled auto-merge September 7, 2022 16:46
@azure-pipelines
Copy link

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12945/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

1 similar comment
@azure-pipelines
Copy link

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12945/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@sebavan sebavan merged commit 43c497e into BabylonJS:master Sep 7, 2022
@bghgary bghgary deleted the optimize-interpolate branch September 7, 2022 22:33
RaananW pushed a commit that referenced this pull request Dec 9, 2022
Optimize animation interpolate function

Former-commit-id: add0a4aeec7a92274a45ac59e169bcae3c6a2286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants