Reducing amount of code in Observable and Logger #12936
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12936/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12936/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12936/merge#BCU1XR#0 |
| Logger.Error(Logger.MessageLimitReached.replace(/%LIMIT%/g, "" + entry.limit).replace(/%TYPE%/g, "error")); | ||
| break; | ||
| } | ||
| Logger.Log(Logger.MessageLimitReached.replace(/%LIMIT%/g, "" + entry.limit).replace(/%TYPE%/g, type.name ?? "")); |
There was a problem hiding this comment.
Shouldn't you use Logger.Log / Logger.Warn / Logger.Error depending on the level?
There was a problem hiding this comment.
i'll fix that, great catch!
Reducing amount of code in Observable and Logger Former-commit-id: 565085ccfa00137e86a62e945f14643d851adfbd
No description provided.