Font Family Drowpdown #12920

amritanarasimhan · 2022-08-30T20:11:22Z

Created a dropdown menu for font family options, with the ability to add custom fonts beyond the ones already provided

azure-pipelines · 2022-08-30T20:29:26Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

azure-pipelines · 2022-08-30T20:51:57Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

azure-pipelines · 2022-08-30T21:12:49Z

Snapshot stored with reference name:
refs/pull/12920/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12920/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12920/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12920/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12920/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12920/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12920/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12920/merge#BCU1XR#0

carolhmj

Awesome job! Just have some considerations to make.

packages/dev/sharedUiComponents/src/lines/optionsLineComponent.tsx

...uiEditor/src/components/propertyTab/propertyGrids/gui/commonControlPropertyGridComponent.tsx

carolhmj · 2022-08-31T15:46:19Z

Doing some testing, I caught this case where if we change a font style and go back to normal style, the style dropdown disappears:

EDIT: Fixed 👍

carolhmj · 2022-08-31T15:52:19Z

Also, if I click on the custom font, click on the textbox and click away without typing anything, it fires the "font doesn't exist in browser" warning. It would be better for the user if this warning didn't fire in case there isn't anything on the input:

EDIT: Fixed 👍

carolhmj · 2022-08-31T16:14:23Z

When clicking away from the font custom input if the input is invalid, the text block "jumps"
https://user-images.githubusercontent.com/6002144/187727609-6b79a01f-9aa9-467a-8c92-d3922c7fe7ee.mp4

carolhmj · 2022-08-31T16:21:38Z

If I set a custom font to an element and then select another element, the custom font is still selected in the dropdown:

Edit: Fixed 👍

carolhmj · 2022-09-01T12:00:06Z

When opening this layout: #BC81Y2#3 and clicking on the "Sales" text label, I got a crash:

EDIT: Same with this layout: #D5CXGS#2. This is probably related to opening a layout with fonts that haven't been loaded yet.

EDIT2: Fixed! Great work!

carolhmj

Getting closer! Just the remaining conversations and issues to solve 😄

RaananW

Great work :-) And a very important PR.

Just have a few suggestions and changes. I will also wait for @carolhmj to approve it as well.

packages/dev/sharedUiComponents/src/lines/optionsLineComponent.tsx

...uiEditor/src/components/propertyTab/propertyGrids/gui/commonControlPropertyGridComponent.tsx

into issue47

RaananW · 2022-09-15T10:29:12Z

There is a formatting issue, and one more when the editor is in pop up mode (in the playground).

The alerts are being triggered on the original window host and not on the popup window. You need to use this.props.globalState.hostWindow.alert instead of only alert

carolhmj

Just a small question :D

packages/dev/sharedUiComponents/src/lines/optionsLineComponent.tsx

carolhmj

Great job! Thank you so much for your work! 🥳

Font Family Drowpdown Former-commit-id: e8bcf607180eeeaf52df25e5e7e68d9ea2caf742

amritanarasimhan added 12 commits August 4, 2022 09:54

create dropdown with 4 example fonts

85614d3

edited font options

c3a3004

added prop & changed select to datalist

aeeb31e

dropdown works

9283a32

user input, correct font changes

8b284ab

validate fonts

41ea8f9

added "add custom font" button

c648d13

store fonts on refresh/rerender

c6e4dea

No remaining errors except 1

3d88e58

Done with dropdown

582f285

edited css

7c343a2

removed unnecessary code

6f90f11

custom font added on changing focus

0d5d23b

sebavan requested a review from RaananW August 31, 2022 14:06

carolhmj suggested changes Aug 31, 2022

View reviewed changes

Fixed requested changes

29658ca

RaananW requested a review from carolhmj September 1, 2022 11:13

carolhmj suggested changes Sep 1, 2022

View reviewed changes

not finished - detecting fonts on load

0ceb21b

RaananW requested changes Sep 6, 2022

View reviewed changes

amritanarasimhan and others added 2 commits September 7, 2022 09:38

Fixed issue of loading custom fonts & code changes

fdcd6ea

Merge branch 'master' into issue47

00992ac

amritanarasimhan added 3 commits September 14, 2022 12:01

update

fd9f06f

Merge branch 'issue47' of https://github.com/amritanarasimhan/Babylon.js

30591d8

into issue47

fixed merge issues

2d4afe7

amritanarasimhan requested review from RaananW and carolhmj and removed request for RaananW and carolhmj September 14, 2022 19:34

carolhmj suggested changes Sep 15, 2022

View reviewed changes

packages/dev/sharedUiComponents/src/lines/optionsLineComponent.tsx Outdated Show resolved Hide resolved

changed alert & removed repeated code

fbe9a23

carolhmj approved these changes Sep 15, 2022

View reviewed changes

RaananW approved these changes Sep 15, 2022

View reviewed changes

formatting

da82300

sebavan enabled auto-merge September 15, 2022 18:25

more formatting

d2b3289

auto-merge was automatically disabled September 15, 2022 18:46
Head branch was pushed to by a user without write access

sebavan enabled auto-merge September 15, 2022 18:48

sebavan merged commit 9a177b0 into BabylonJS:master Sep 15, 2022

RaananW pushed a commit that referenced this pull request Dec 9, 2022

Merge pull request #12920 from amritanarasimhan/issue47

5ec6925

Font Family Drowpdown Former-commit-id: e8bcf607180eeeaf52df25e5e7e68d9ea2caf742

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Font Family Drowpdown #12920

Font Family Drowpdown #12920

amritanarasimhan commented Aug 30, 2022

azure-pipelines bot commented Aug 30, 2022

azure-pipelines bot commented Aug 30, 2022

azure-pipelines bot commented Aug 30, 2022

carolhmj left a comment

carolhmj commented Aug 31, 2022 •

edited

Loading

carolhmj commented Aug 31, 2022 •

edited

Loading

carolhmj commented Aug 31, 2022

carolhmj commented Aug 31, 2022 •

edited

Loading

carolhmj commented Sep 1, 2022 •

edited

Loading

carolhmj left a comment

RaananW left a comment

RaananW commented Sep 15, 2022

carolhmj left a comment

carolhmj left a comment

Font Family Drowpdown #12920

Font Family Drowpdown #12920

Conversation

amritanarasimhan commented Aug 30, 2022

azure-pipelines bot commented Aug 30, 2022

azure-pipelines bot commented Aug 30, 2022

azure-pipelines bot commented Aug 30, 2022

carolhmj left a comment

Choose a reason for hiding this comment

carolhmj commented Aug 31, 2022 • edited Loading

carolhmj commented Aug 31, 2022 • edited Loading

carolhmj commented Aug 31, 2022

carolhmj commented Aug 31, 2022 • edited Loading

carolhmj commented Sep 1, 2022 • edited Loading

carolhmj left a comment

Choose a reason for hiding this comment

RaananW left a comment

Choose a reason for hiding this comment

RaananW commented Sep 15, 2022

carolhmj left a comment

Choose a reason for hiding this comment

carolhmj left a comment

Choose a reason for hiding this comment

carolhmj commented Aug 31, 2022 •

edited

Loading

carolhmj commented Aug 31, 2022 •

edited

Loading

carolhmj commented Aug 31, 2022 •

edited

Loading

carolhmj commented Sep 1, 2022 •

edited

Loading