Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Drag/Release Behavior in GUI and Photo Dome #12887

Merged
merged 4 commits into from
Aug 22, 2022
Merged

Fix Drag/Release Behavior in GUI and Photo Dome #12887

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
78d50c3
Fix Drag/Release Behavior in GUI and Photo Dome
stevendelapena Aug 18, 2022
ed03efe
Merge pull request #1 from stevendelapena/stevendelapena-patch-1
stevendelapena Aug 19, 2022
652b730
Merge branch 'BabylonJS:master' into master
stevendelapena Aug 19, 2022
c1cd489
Added type cast to IPointerEvent
stevendelapena Aug 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added type cast to IPointerEvent
  • Loading branch information
@stevendelapena
stevendelapena authored Aug 20, 2022
commit c1cd489cad076a19d6d3e804795ac8a1ec96167f
2 changes: 1 addition & 1 deletion packages/dev/gui/src/2D/advancedDynamicTexture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,7 +886,7 @@ export class AdvancedDynamicTexture extends DynamicTexture {
const tempViewport = new Viewport(0, 0, 0, 0);

this._prePointerObserver = scene.onPrePointerObservable.add((pi) => {
if (scene.isPointerCaptured(pi.event.pointerId) && pi.type === PointerEventTypes.POINTERUP) {
if (scene.isPointerCaptured((<IPointerEvent>pi.event).pointerId) && pi.type === PointerEventTypes.POINTERUP) {
return;
}
if (
Expand Down