Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boolean invertDirection to allow inverting the scrollbar navigati… #12867

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Add boolean invertDirection to allow inverting the scrollbar navigati… #12867

merged 2 commits into from
Aug 18, 2022

Conversation

carolhmj
Copy link
Contributor

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think invertDirection might be confusing. Maybe invertScrollDirection? invertDirection might be considered inverting the direction of the component itself

@carolhmj
Copy link
Contributor Author

I think invertDirection might be confusing. Maybe invertScrollDirection? invertDirection might be considered inverting the direction of the component itself

Makes sense, changed the name!

@carolhmj carolhmj requested a review from RaananW August 17, 2022 14:41
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@azure-pipelines
Copy link

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12867/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@sebavan sebavan enabled auto-merge August 18, 2022 01:25
@sebavan sebavan merged commit 2900529 into BabylonJS:master Aug 18, 2022
@carolhmj carolhmj deleted the invertScrollbarDirection branch August 19, 2022 13:53
RaananW pushed a commit that referenced this pull request Dec 9, 2022
Add boolean invertDirection to allow inverting the scrollbar navigati…

Former-commit-id: 4b82123b60ec8e16ab2595e13b38fea56f5e3479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants