Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defensive URL detection #12810

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Defensive URL detection #12810

merged 2 commits into from
Jul 29, 2022

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Jul 29, 2022

Make sure the environment running babylon has the URL object before using it.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12810/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12810/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12810/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12810/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12810/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12810/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12810/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12810/merge#BCU1XR#0

@deltakosh deltakosh merged commit 980aaa8 into BabylonJS:master Jul 29, 2022
@RaananW RaananW deleted the URL-typing branch July 29, 2022 15:25
RaananW added a commit that referenced this pull request Dec 9, 2022
@RaananW
Defensive URL detection (#12810)
5091ca8 
* Defensive URL detection

* formatting

Former-commit-id: 9063cbf264ba63b4e1541ed8103dca34ba666820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltakosh deltakosh deltakosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RaananW @deltakosh